Bug in FIRFilter ?

Forum for discussion on different signal processing algorithms
Locked
M_Spueler
Posts: 3
Joined: 26 Sep 2007, 07:26

Bug in FIRFilter ?

Post by M_Spueler » 03 Dec 2010, 07:26

Just wanted to know if this is a bug in FIRFilter or only a problem with my setup. I generated Filter coefficients with matlab and the output of FIRFilter looks completly different than i expect it to be.

changing following line

Code: Select all

result[sample] = inner_product( &mFilter[channel][0], &mFilter[channel][filterLength-1], &mBuffer[channel][sample], 0 );
to

Code: Select all

result[sample] = inner_product( &mFilter[channel][0], &mFilter[channel][filterLength-1], &mBuffer[channel][sample], 0.0);
solved the problem. Seems like there is some internal int casting going on due to the 0

mellinger
Posts: 1071
Joined: 12 Feb 2003, 11:06

Post by mellinger » 03 Dec 2010, 09:16

Thanks a lot for reporting this bug.
It was fixed in BCI2000 v3, but still present in v2.1.

--Juergen

Locked

Who is online

Users browsing this forum: No registered users and 0 guests